-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAYA-110155: consistent namespace across the project - Part 2 #1231
MAYA-110155: consistent namespace across the project - Part 2 #1231
Conversation
HamedSabri-adsk
commented
Mar 3, 2021
- colorSpace
- blockSceneModificationContext
@@ -19,16 +19,22 @@ | |||
|
|||
PXR_NAMESPACE_USING_DIRECTIVE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forced to keep this here because of "PIXMAYA_LINEAR_COLORS"
lib/mayaUsd/nodes/hdImagingShape.cpp
Outdated
@@ -207,7 +207,7 @@ MObject PxrMayaHdImagingShape::GetOrCreateInstance() | |||
// We never intend for the imaging shape to get saved out to the Maya scene | |||
// file, so make sure that we preserve the scene modification status from | |||
// before we create the shape. | |||
const UsdMayaBlockSceneModificationContext blockModContext; | |||
const MayaUsd::utils::UsdMayaBlockSceneModificationContext blockModContext; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply a reminder of internal discussion - let's remove the UsdMaya
prefix since it's not very useful when the class now lives in the proper namespace.
@HamedSabri-adsk please resolve merge conflicts and trigger a PF. |